Repository navigation
Release v0.1.0 - #13
Merged
Merged
Conversation
Laravel 11+ ships a native Request::array(), which wins over core-api's macro of that name and stops it splitting comma-separated values. Needs core-api with inputArray.
Set the version in composer.json, package.json and extension.json, start RELEASE.md, and run CI on pull requests into release/v* and dev-v*.
PHPStan 2 removed checkMissingIterableValueType (now always on) and checkGenericClassInNonGenericObjectType; the missingType.generics identifier keeps the old behaviour. The old baseline no longer matched PHPStan 2's messages, so it is regenerated: 542 pre-existing errors, all in code that predates this branch. New code is still held to level max.
PHPStan 2 reports the parameter as array<mixed> rather than array<T>, so the baseline entry no longer matched and the error was reported.
feat!: move to Laravel 12 and core-api 2.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
============================================
+ Coverage 26.49% 26.84% +0.35%
Complexity 643 643
============================================
Files 19 19
Lines 2265 2265
============================================
+ Hits 600 608 +8
+ Misses 1665 1657 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The v0.1.0 release changes saveServerConfig to read the request with core-api's inputArray(), and Codecov's patch check failed with that line uncovered. The test saves settings over the defaults into SQLite. This package's dev install has no laravel/framework, so the test supplies guarded stand-ins for the Foundation traits, FormRequest, config() and response().
The README was mostly an essay on Solid for logistics, with PHP ^8.1, Node and license details that no longer match. It now follows the other extensions' README layout, with features, routes, configuration and development steps taken from the code.
docs(readme): rewrite the README for v0.1.0
test(server-config): cover saving the Solid server settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.1.0: the Laravel 12 release, for fleetbase/fleetbase
release/v0.8.0.This branch already sets the version in
composer.json,package.jsonandextension.json, startsRELEASE.mdwith the linerelease.ymlchecks, and runs CI on pull requests intorelease/v*anddev-v*.Merge into
release/v0.1.0firstThen finish
RELEASE.mdwith anything else that lands here.Tag after
Composer can't resolve these until they are tagged, so CI on this PR stays red until then.
Do not merge or tag until the PRs above are merged and green.